Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
awslabs/aws-sdk-swift#1458
Description of changes
Removes the namespace around nested model types to reduce boilerplate and simplify service clients. Results in the following changes to a service's models:
OperationInput
andOperationOutput
(to resolve name collision with a couple services that have names that clash with the currentInput
andOutput
names.)ServiceClientTypes
and are created in the root namespace of the service.Specific changes made to support:
NestedTrait
and the transformer that applies it are removed, since no models are nested anymore.Input
andOutput
toOperationInput
andOperationOutput
. This was needed to avoid name collisions after renaming.Note: Many codegen tests are broken due to changed names. Will fix once we settle on naming structure.
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.